[Pidgin] #12562: Pidgin IRC does not handle SSL blocks of > IRC_INITIAL_BUFSIZE correctly

Pidgin trac at pidgin.im
Sat Jan 2 23:53:28 EST 2016


#12562: Pidgin IRC does not handle SSL blocks of > IRC_INITIAL_BUFSIZE correctly
-------------------------------------------------+------------------
 Reporter:  Stmeter                              |       Owner:  elb
     Type:  defect                               |      Status:  new
Milestone:                                       |   Component:  IRC
  Version:  2.7.3                                |  Resolution:
 Keywords:  SSL inspircd packets gnutls openssl  |
-------------------------------------------------+------------------

Comment (by dx):

 Attached test case server. Not the greatest code but does the job.
 Probably requires python2 instead of python3. Copying instructions here:

 {{{
 # test case irc server for pidgin bug #12562. usage:
 #
 #   openssl req -batch -nodes -x509 -newkey rsa:2048 -keyout server.key
 -out server.pem
 #   python server.py
 #   python server.py 2
 #
 # the arg is the number of 512-byte filler messages. 2 is enough to break
 it.
 }}}

 Quoting myself from the dev channel:

 > <dx> i think this bug is a problem that applies to all prpls that use
 ssl, not just irc
 >
 > <dx> or maybe irc just happens to be the one protocol with the lowest
 buffer size, 1024
 >
 > <dx> i can't find anything equivalent to this
 https://github.com/bitlbee/bitlbee/blob/0db6618/lib/ssl_gnutls.c#L425-L443
 >
 > <dx> or this
 https://github.com/bitlbee/bitlbee/blob/0db6618/lib/ssl_nss.c#L287-L296
 >
 > <dx> maybe recv_cb in sslconn.c should keep calling the callback while
 that condition is true
 >
 > <dx> this probably means adding another ssl op though

--
Ticket URL: <https://developer.pidgin.im/ticket/12562#comment:2>
Pidgin <https://pidgin.im>
Pidgin


More information about the Tracker mailing list