[Pidgin] #17238: Finch search results don't clear on update

[Pidgin]

#17238: Finch search results don't clear on update
--------------------+---------------------------------
 Reporter:  dwmw2   |      Owner:  sadrul
     Type:  defect  |     Status:  new
Milestone:  2.12.1  |  Component:  finch (gnt/ncurses)
  Version:  2.12.0  |   Keywords:
--------------------+---------------------------------
 {{{
 $ grep -A6 ^finch_notify_sr_new_rows gntnotify.c
 finch_notify_sr_new_rows(PurpleConnection *gc,
                 PurpleNotifySearchResults *results, void *data)
 {
         GntTree *tree = GNT_TREE(data);
         GList *o;

         /* XXX: Do I need to empty the tree here? */
 }}}

 Yes, you do ;)

 I implemented a PRPL which shows users' status in search results and uses
 `purple_notify_searchresults_new_rows()` when it updates. But every time,
 Finch just appends the new results to the old ones:

 {{{
 ┌────────────────┤User autocomplete├───────────────┐
 │Search results                                    │
 │┌───────────────┬───────────────┬────────────────┐│
 ││Name           │Email          │Availability    ││
 ││───────────────┼───────────────┼────────────────││
 ││Woodhouse, Dav…│dwmw at amazon.co…│Busy            ││
 ││Woodhouse, Dav…│dwmw at amazon.co…│Available      ▒││
 ││Woodhouse, Dav…│dwmw at amazon.co…│Busy           ▒││
 ││               │               │               ▒││
 ││               │               │               ▒││
 ││               │               │                ││
 │└───────────────┴───────────────┴────────────────┘│
 │                   ┌─────┐ ┌────┐                 │
 │                   │ Add │ │ IM │                 │
 │                   └─────┘ └────┘                 │
 └──────────────────────────────────────────────────┘
 }}}

 This works correctly in Pidgin. (Btw it'd be really nice to be able to
 display their status as an icon like in the buddy list, rather than just
 text. But that's a request for another day...)

--
Ticket URL: <https://developer.pidgin.im/ticket/17238>
Pidgin <https://pidgin.im>
Pidgin