[Pidgin] #17292: Search results memory leak

[Pidgin]

#17292: Search results memory leak
--------------------+--------------------------
 Reporter:  dwmw2   |      Owner:  EionRobb
     Type:  defect  |     Status:  new
Milestone:  2.13.0  |  Component:  unclassified
  Version:  2.12.0  |   Keywords:
--------------------+--------------------------
 Repeated calls pidgin_notify_searchresults_new_rows() will always leak the
 results. I'm not actually sure why we keep data->results around at all; do
 we actually need it? We're using g_value_set_string() to build the GTK
 table, not g_value_set_static_string(). Couldn't we just free the results
 immediately, and ditch data->results altogether?

 Alternatively, here's a minimal fix to keep working the way we do, in case
 I missed the reason for that.

--
Ticket URL: <https://developer.pidgin.im/ticket/17292>
Pidgin <https://pidgin.im>
Pidgin