[Pidgin] #17292: Search results memory leak
Pidgin
trac at pidgin.im
Thu Mar 8 05:11:23 EST 2018
#17292: Search results memory leak
--------------------+---------------------------
Reporter: dwmw2 | Owner: EionRobb
Type: patch | Status: new
Milestone: 2.13.0 | Component: unclassified
Version: 2.12.0 | Resolution:
Keywords: |
--------------------+---------------------------
Comment (by dwmw2):
Note, the patch above fixes '''two''' leaks. Firstly, using
`g_value_set_string()` was leaking the strings because after being
duplicated into the GValue, they don't ever get freed. Secondly, the old
`data->results` was being leaked on each update.
AFAICT the only ''point'' in keeping `data->results` around in the first
place was if we thought we were using `g_value_set_static_string()` and
using the copy from there anyway, so that's the approach my patch takes.
--
Ticket URL: <https://developer.pidgin.im/ticket/17292#comment:6>
Pidgin <https://pidgin.im>
Pidgin
More information about the Tracker
mailing list