[Pidgin] #17292: Search results memory leak

Pidgin trac at pidgin.im
Thu Mar 8 08:25:50 EST 2018


#17292: Search results memory leak
--------------------+---------------------------
 Reporter:  dwmw2   |       Owner:  EionRobb
     Type:  patch   |      Status:  new
Milestone:  2.13.0  |   Component:  unclassified
  Version:  2.12.0  |  Resolution:
 Keywords:          |
--------------------+---------------------------

Comment (by dwmw2):

 OK, that's one's better. We keep around the ''original'' `data->results`
 since we're using the buttons out of that one. New updates can be freed
 straight away.

 We can use `g_value_set_static_string()` because we're not giving it away
 to `gtk_list_store_set_value()` at all. The problem there was a lack of
 `g_value_unset(&v)` in our own loop, but we can do without that by just
 using `g_value_set_static_string()` and avoiding a pointless malloc/free.

--
Ticket URL: <https://developer.pidgin.im/ticket/17292#comment:8>
Pidgin <https://pidgin.im>
Pidgin


More information about the Tracker mailing list