[Pidgin] #17380: Tor Proxy and SOCKS5 requires username/password in settings

[Pidgin]

#17380: Tor Proxy and SOCKS5 requires username/password in settings
--------------------+---------------------
 Reporter:  hefee   |      Owner:  bleeter
     Type:  defect  |     Status:  new
Milestone:          |  Component:  privacy
  Version:  2.12.0  |   Keywords:
--------------------+---------------------
 If I use tor as proxy in pidgin with SOCKS4 everything works fine
 (localhost, port 9050).
 When use SOCKS5 and leave username password empty pidgin fails with an
 error error. It fails with the same error when I use "Tor/Privacy
 (SOCKS5)" proxy setting. The debug log i got by `pidgin -d`:

 {{{
 (15:26:20) jabber: Unable to connect to server: general SOCKS server
 failure
 .  Trying next SRV record or connecting directly.
 (15:26:20) dnsquery: Performing DNS lookup for 127.0.0.1
 (15:26:20) dnsquery: IP resolved for 127.0.0.1
 (15:26:20) proxy: Attempting connection to 127.0.0.1
 (15:26:20) proxy: Connecting to server.net:5222 via 127.0.0.1:9050 using
 SOCKS5
 (15:26:20) socks5 proxy: Connection in progress
 (15:26:20) socks5 proxy: Connected.
 (15:26:20) socks5 proxy: Able to read.
 (15:26:20) socks5 proxy: Got auth response.
 (15:26:20) socks5 proxy: general SOCKS server failure
 (15:26:20) proxy: Connection attempt failed: general SOCKS server failure

 (15:26:20) jabber: Couldn't connect directly to server.net.  Trying to
 find alternative connection methods, like BOSH.
 (15:26:20) dnssrv: querying TXT record for server.net:
 _xmppconnect.server.net
 (15:26:20) dnssrv: res_query returned an error
 (15:26:20) jabber: Unable to find alternative XMPP connection methods
 after failing to connect directly.
 (15:26:20) connection: Connection error on 0x56057f249790 (reason: 0
 description: Unable to connect)
 (15:26:20) account: Disconnecting account XXX at XXX.XX/ (0x56057e274b10)
 (15:26:20) connection: Disconnecting connection 0x56057f249790
 (15:26:20) connection: Destroying connection 0x56057f249790
 }}}

 if I enter any username/password it connects successfully:

 {{{
 (15:28:32) dnsquery: Performing DNS lookup for 127.0.0.1
 (15:28:32) dnsquery: IP resolved for 127.0.0.1
 (15:28:32) proxy: Attempting connection to 127.0.0.1
 (15:28:32) proxy: Connecting to server.net:5222 via 127.0.0.1:9050 using
 SOCKS5
 (15:28:32) socks5 proxy: Connection in progress
 (15:28:32) socks5 proxy: Connected.
 (15:28:32) socks5 proxy: Able to read.
 (15:28:32) socks5 proxy: Got auth response.
 (15:28:32) s5: reallocing from 5 to 8
 (15:28:32) s5: reallocing from 8 to 10
 (15:28:32) proxy: Connected to server.net:5222.
 }}}

 This sounds like an error for pidgin, as I can run curl by command line
 without any authentication:

 {{{
 $ curl --socks5 localhost:9050 --socks5-hostname localhost:9050 -s
 https://check.torproject.org/ | cat | grep -m 1 Congratulations | xargs
 Congratulations. This browser is configured to use Tor.
 }}}


 Used software:
 Tails 3.12 - pidgin 2.12.0, tor 0.3.5.7
 Debian unstable - pidgin 2.13.0, tor 0.3.5.7

 with tor 0.3.4 pidgin can connects successfully.

--
Ticket URL: <https://developer.pidgin.im/ticket/17380>
Pidgin <https://pidgin.im>
Pidgin