Revision 45666c61a140448a2974f59f1bee801bdc8a4ab2

Mark Doliner mark at kingant.net
Sun Feb 25 15:45:40 EST 2007


On Sun, 25 Feb 2007 14:19:20 -0500 (EST), evands wrote
> -----------------------------------------------------------------
> Revision: 45666c61a140448a2974f59f1bee801bdc8a4ab2
> Ancestor: ea122c13e0aa3ae0fb04f42991ba0b7c2b5c30c0
> Author: evands at pidgin.im
> Date: 2007-02-25T19:18:12
> Branch: im.pidgin.pidgin
> 
> Modified files:
>         libpurple/dnsquery.c
> 
> ChangeLog:
> 
> Return -1 as 'invalid port' if passed NULL in gaim_dnsquery_get_port()

It might be better to return an unsigned short and use 0 as 'invalid port'
(that's what the code in network.c does).  Also, some of your indentation in
the UI DNS resolution commit was strangely inconsistent :-)

-Mark


More information about the Commits mailing list