Revision 45666c61a140448a2974f59f1bee801bdc8a4ab2

Evan Schoenberg evan.s at
Sun Feb 25 16:14:11 EST 2007

On Feb 25, 2007, at 3:45 PM, Mark Doliner wrote:

>> Modified files:
>>         libpurple/dnsquery.c
>> ChangeLog:
>> Return -1 as 'invalid port' if passed NULL in  
>> gaim_dnsquery_get_port()
> It might be better to return an unsigned short and use 0 as  
> 'invalid port'
> (that's what the code in network.c does).  Also, some of your  
> indentation in
> the UI DNS resolution commit was strangely inconsistent :-)

'k, I'll fix both of these in the near future.

Indentation problems are because I've uninstalled my normal coding  
IDE (XCode) to force myself to do proper work until the week's end...  
but then a conversation with Graham led to me doing some coding,  
which I did in a different text editor that apparently defaults to  
using spaces instead of tabs.

-------------- next part --------------
An HTML attachment was scrubbed...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : 

More information about the Commits mailing list