pidgin: 070b5690: Remove unneeded forward declarations. I...

markdoliner at markdoliner at
Fri Dec 12 14:35:33 EST 2008

Revision: 070b5690a0cababc2874a718e80c245538a231c4
Ancestor: a61cfe7538023b0a9972ce7679cfa8bcda2b6a35
Author: markdoliner at
Date: 2008-12-12T19:34:34
Branch: im.pidgin.pidgin

Modified files:


Remove unneeded forward declarations.  I guess my philosophy is to only
forward declare static functions if it's actually needed (like if two
static functions call each other, or for other more complex circular

-------------- next part --------------
--- libpurple/protocols/myspace/markup.c	949ebca754deed423ad2be285775a3587cf7e627
+++ libpurple/protocols/myspace/markup.c	e35d67c443dfdccfc21e39d883a47f92a1647a1f
@@ -21,20 +21,6 @@ typedef int (*MSIM_XMLNODE_CONVERT)(Msim
 typedef int (*MSIM_XMLNODE_CONVERT)(MsimSession *, xmlnode *, gchar **, gchar **);
-/* Internal functions */
-static guint msim_point_to_purple_size(MsimSession *session, guint point);
-static guint msim_purple_size_to_point(MsimSession *session, guint size);
-static guint msim_height_to_point(MsimSession *session, guint height);
-static guint msim_point_to_height(MsimSession *session, guint point);
-static int msim_markup_tag_to_html(MsimSession *, xmlnode *root, gchar **begin, gchar **end);
-static int html_tag_to_msim_markup(MsimSession *, xmlnode *root, gchar **begin, gchar **end);
-static gchar *msim_convert_xml(MsimSession *, const gchar *raw, MSIM_XMLNODE_CONVERT f);
-static gchar *msim_convert_smileys_to_markup(gchar *before);
-static double msim_round(double round);
 /* Globals */
 /* The names in in emoticon_names (for <i n=whatever>) map to corresponding 
@@ -118,7 +104,7 @@ static gdouble _font_scale[] = { .85, .9
 /* round is part of C99, but sometimes is unavailable before then.
  * Based on
-double msim_round(double value)
+static double msim_round(double value)
 	if (value < 0) {
 		return -(floor(-value + 0.5));

More information about the Commits mailing list