pidgin: 5f6a901d: Move this check inside the else conditio...

[markdoliner at pidgin.im]

-----------------------------------------------------------------
Revision: 5f6a901d7c3daae033e6d06fec2d2d1abbdcbbde
Ancestor: acf4cce929cd032affb8793d84b0506d8867e04c
Author: markdoliner at pidgin.im
Date: 2009-08-12T23:13:47
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/5f6a901d7c3daae033e6d06fec2d2d1abbdcbbde

Modified files:
        libpurple/protocols/msn/slplink.c

ChangeLog: 

Move this check inside the else condition.  The other half of the if
statement guarrantees that slpmsg will be non-NULL, this is a very
tiny optimization, but it's also cleaner

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/slplink.c	c9067bc51fc08b6bfa6d9028430d666339d27c0c
+++ libpurple/protocols/msn/slplink.c	04fd3b72538b01c4ec83fa596a37340af5f19d3c
@@ -502,7 +502,6 @@ msn_slplink_process_msg(MsnSlpLink *slpl
 		g_return_if_reached();
 	}
 
-	slpmsg = NULL;
 	data = msn_message_get_bin_data(msg, &len);
 
 	/*
@@ -566,15 +565,14 @@ msn_slplink_process_msg(MsnSlpLink *slpl
 	else
 	{
 		slpmsg = msn_slplink_message_find(slplink, msg->msnslp_header.session_id, msg->msnslp_header.id);
+		if (slpmsg == NULL)
+		{
+			/* Probably the transfer was canceled */
+			purple_debug_error("msn", "Couldn't find slpmsg\n");
+			return;
+		}
 	}
 
-	if (slpmsg == NULL)
-	{
-		/* Probably the transfer was canceled */
-		purple_debug_error("msn", "Couldn't find slpmsg\n");
-		return;
-	}
-
 	if (slpmsg->fp)
 	{
 		/* fseek(slpmsg->fp, offset, SEEK_SET); */