pidgin: b981c8ff: Ignore unknown MySpace messages instead ...

[markdoliner at pidgin.im]

-----------------------------------------------------------------
Revision: b981c8ff584faae28ac42f9fa3e4d3678a19cd5a
Ancestor: 5f6a901d7c3daae033e6d06fec2d2d1abbdcbbde
Author: markdoliner at pidgin.im
Date: 2009-08-13T00:01:21
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/b981c8ff584faae28ac42f9fa3e4d3678a19cd5a

Modified files:
        libpurple/protocols/myspace/myspace.c

ChangeLog: 

Ignore unknown MySpace messages instead of trying to treat them like
normal IMs.  This can cause problems if MySpace ever sends an uknown
message type and we try to treat it as an IM.

-------------- next part --------------
============================================================
--- libpurple/protocols/myspace/myspace.c	8f54dae1ecff9956971bfe905d19a55650a5e444
+++ libpurple/protocols/myspace/myspace.c	71ae7fc8b2c859517e62901192c558815f9c18ec
@@ -1693,10 +1693,16 @@ msim_incoming_bm(MsimSession *session, M
 		case MSIM_BM_UNOFFICIAL_CLIENT:
 			return msim_incoming_unofficial_client(session, msg);
 		default:
-			/* Not really an IM, but show it for informational
-			 * purposes during development. */
-			/* TODO: This is probably wrong */
-			return msim_incoming_action_or_im(session, msg);
+			/*
+			 * Unknown message type!  We used to call
+			 *   msim_incoming_action_or_im(session, msg);
+			 * for these, but that doesn't help anything, and it means
+			 * we'll show broken gibberish if MySpace starts sending us
+			 * other message types.
+			 */
+			purple_debug_warning("myspace", "Received unknown imcoming "
+					"message, bm=%u\n", bm);
+			return TRUE;
 	}
 }