pidgin: 894e51e3: Remove a handful of string utility funct...

deryni at pidgin.im deryni at pidgin.im
Wed Jan 7 09:05:54 EST 2009


-----------------------------------------------------------------
Revision: 894e51e3fe73971f510344112de71a2b027d4499
Ancestor: c4f034d22d3a0ec8eb6f3e0dfd5802b978cbf4c2
Author: deryni at pidgin.im
Date: 2009-01-07T03:31:23
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/894e51e3fe73971f510344112de71a2b027d4499

Modified files:
        ChangeLog.API libpurple/plugins/perl/common/Util.xs

ChangeLog: 

Remove a handful of string utility functions from perl, they are generally
better handled by perl's built-in functions and at least two of them are
reported to crash currently.

References #6562

-------------- next part --------------
============================================================
--- ChangeLog.API	c95d5849f617bff9d7384685aca82bade4be9f4a
+++ ChangeLog.API	3738bad3377c03debde636f84c7c73921efd97d1
@@ -6,6 +6,16 @@ version 2.5.4 (??/??/????):
 		* Purple::PluginPref->get_bounds no longer takes two integer
 		  arguments it now returns two integers.
 
+		Removed:
+		* Removed a handful of string-related utility functions that
+		  can generally be better handled with perl's built-in string
+		  functions rather than using pidgin's:
+			* Purple::Util::strcasereplace
+			* Purple::Util::strcasestr
+			* Purple::Util::strreplace
+			* Purple::Util::str_strip_char
+			* Purple::Util::chrreplace
+
 version 2.5.3 (12/20/2008):
 	libpurple
 		Changed:
============================================================
--- libpurple/plugins/perl/common/Util.xs	3428ec628bf8dddffe068b26bfc42a539a9e8b7b
+++ libpurple/plugins/perl/common/Util.xs	37fb61f65cac9ff956cf54e0dfa9bebcc4141699
@@ -99,27 +99,10 @@ gchar_own *
 	const char *program
 
 gchar_own *
-purple_strcasereplace(string, delimiter, replacement)
-	const char *string
-	const char *delimiter
-	const char *replacement
-
-const char *
-purple_strcasestr(haystack, needle)
-	const char *haystack
-	const char *needle
-
-gchar_own *
 purple_strdup_withhtml(src)
 	const gchar *src
 
 gchar_own *
-purple_strreplace(string, delimiter, replacement)
-	const char *string
-	const char *delimiter
-	const char *replacement
-
-gchar_own *
 purple_text_strip_mnemonic(in)
 	const char *in
 
@@ -356,10 +339,6 @@ purple_str_size_to_units(size)
 purple_str_size_to_units(size)
 	size_t size
 
-void
-purple_str_strip_char(IN_OUT char str, thechar)
-	char thechar
-
 time_t
 purple_str_to_time(timestamp, utc = FALSE, tm = NULL, OUTLIST long tz_off, OUTLIST const char *rest)
 	const char *timestamp
@@ -512,11 +491,6 @@ purple_util_set_current_song(title, arti
 	const char *artist
 	const char *album
 
-void
-purple_util_chrreplace(IN_OUT char string, delimiter, replacement)
-	char delimiter
-	char replacement
-
 gchar_own*
 purple_util_format_song_info(title, artist, album, unused)
 	const char* title


More information about the Commits mailing list