pidgin: 867b899f: Make Purple::PluginPref->get_bounds be m...

[deryni at pidgin.im]

-----------------------------------------------------------------
Revision: 867b899f8aaf7afeaad8911ddf39fe2bada11d2d
Ancestor: 479fd75025803f01e743b5c39e6706b1d42a3520
Author: deryni at pidgin.im
Date: 2009-01-06T05:36:39
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/867b899f8aaf7afeaad8911ddf39fe2bada11d2d

Modified files:
        ChangeLog.API libpurple/plugins/perl/common/PluginPref.xs

ChangeLog: 

Make Purple::PluginPref->get_bounds be more perl-like.

It no longer expects to be called as:
	$ppref->get_bounds($min, $max)
or
	$ppref->get_bounds(\$min, \$max)
(I'm not even sure which one of those was intended to be correct, but
apparently they both crash.)

It now expects to be called like this:
	my ($min, $max) = $ppref->get_bounds();

-------------- next part --------------
============================================================
--- ChangeLog.API	dd109ea26abbe9b0b10a714d4a51d11ef5545a44
+++ ChangeLog.API	c95d5849f617bff9d7384685aca82bade4be9f4a
@@ -1,5 +1,11 @@ Pidgin and Finch: The Pimpin' Penguin IM
 Pidgin and Finch: The Pimpin' Penguin IM Clients That're Good for the Soul
 
+version 2.5.4 (??/??/????):
+	perl:
+		Changed:
+		* Purple::PluginPref->get_bounds no longer takes two integer
+		  arguments it now returns two integers.
+
 version 2.5.3 (12/20/2008):
 	libpurple
 		Changed:
============================================================
--- libpurple/plugins/perl/common/PluginPref.xs	2d22b5c67ace354c106245e41a8c1eff6116760a
+++ libpurple/plugins/perl/common/PluginPref.xs	276b66e1614aee3a2f3a260f70fa41b66c9dc003
@@ -70,10 +70,16 @@ void
 
 
 void
-purple_plugin_pref_get_bounds(pref, min, max)
+purple_plugin_pref_get_bounds(pref, OUTLIST int min, OUTLIST int max)
 	Purple::PluginPref pref
-	int *min
-	int *max
+	# According to the perlxs manual page we shouldn't need to specify a
+	# prototype here because "[p]arameters preceded by OUTLIST keyword do
+	# not appear in the usage signature of the generated Perl function."
+	# however that appears to only work for the usage error message and
+	# not for the call to newXSproto. Since I can't find any documentation
+	# for newXSproto at the moment I have no idea if that matters so
+	# override the prototype here.
+	PROTOTYPE: $
 
 void
 purple_plugin_pref_get_choices(pref)