pidgin: 820fba0e: Fix a small leak and remove a duplicate ...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Wed Jul 22 16:48:36 EDT 2009


-----------------------------------------------------------------
Revision: 820fba0e89ad10b338f7b5508615ab1367dec085
Ancestor: 60315e01b2e3725bb5d272284c3f11d31f18c114
Author: darkrain42 at pidgin.im
Date: 2009-07-22T19:48:51
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/820fba0e89ad10b338f7b5508615ab1367dec085

Modified files:
        libpurple/protocols/jabber/google.c

ChangeLog: 

Fix a small leak and remove a duplicate xmlnode_set_attrib.

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/google.c	7779b1dbc00ca15c7c6e2304a244f6149b88c2db
+++ libpurple/protocols/jabber/google.c	f7d541a5103c3758da7961de41c6d5b123a53040
@@ -982,21 +982,17 @@ void jabber_google_roster_outgoing(Jabbe
 	PurpleAccount *account = purple_connection_get_account(js->gc);
 	GSList *list = account->deny;
 	const char *jid = xmlnode_get_attrib(item, "jid");
-	char *jid_norm = g_strdup(jabber_normalize(account, jid));
+	char *jid_norm = jabber_normalize(account, jid);
 
 	while (list) {
 		if (!strcmp(jid_norm, (char*)list->data)) {
 			xmlnode_set_attrib(query, "xmlns:gr", "google:roster");
-			xmlnode_set_attrib(item, "gr:t", "B");
-			xmlnode_set_attrib(query, "xmlns:gr", "google:roster");
 			xmlnode_set_attrib(query, "gr:ext", "2");
+			xmlnode_set_attrib(item, "gr:t", "B");
 			return;
 		}
 		list = list->next;
 	}
-
-	g_free(jid_norm);
-
 }
 
 gboolean jabber_google_roster_incoming(JabberStream *js, xmlnode *item)


More information about the Commits mailing list