pidgin: 60337efb: Make sure we free itmsurl when showing t...

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Mar 27 06:00:50 EDT 2009


-----------------------------------------------------------------
Revision: 60337efb2a796d1164c234e7b55ccab5cb75246e
Ancestor: 4a09c5cff1884765bcbb5fd413a0265d25b5582c
Author: markdoliner at pidgin.im
Date: 2009-03-27T09:48:25
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/60337efb2a796d1164c234e7b55ccab5cb75246e

Modified files:
        libpurple/protocols/msn/cmdproc.c
        libpurple/protocols/oscar/oscar.c

ChangeLog: 

Make sure we free itmsurl when showing the info window for a buddy
with an itunes music store url

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/cmdproc.c	26f32ef7f803692995d9028c0655440151d22168
+++ libpurple/protocols/msn/cmdproc.c	b158005f2b57746c6144bf53849d6558a67bdc66
@@ -117,8 +117,10 @@ msn_cmdproc_send_trans(MsnCmdProc *cmdpr
 
 	servconn = cmdproc->servconn;
 
-	if (!servconn->connected)
+	if (!servconn->connected) {
+		/* TODO: Need to free trans */
 		return;
+	}
 
 	msn_history_add(cmdproc->history, trans);
 
============================================================
--- libpurple/protocols/oscar/oscar.c	d6d590797e9b1b184047b520fd523c565e26799d
+++ libpurple/protocols/oscar/oscar.c	789c6dcec44a528997926f1810fd0936a76712d1
@@ -870,11 +870,11 @@ static void oscar_user_info_append_statu
 		if (itmsurl) {
 			tmp = g_strdup_printf("<a href=\"%s\">%s</a>",
 								  itmsurl, message);
-			g_free(itmsurl);
 			g_free(message);
 			message = tmp;
 		}
 	}
+	g_free(itmsurl);
 
 	if (is_away && message) {
 		tmp = purple_str_sub_away_formatters(message, purple_account_get_username(account));


More information about the Commits mailing list