pidgin: 6c9e5e62: Fix a potential memleak by freeing this ...

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Mar 27 06:00:51 EDT 2009


-----------------------------------------------------------------
Revision: 6c9e5e620e4f484c5665cf27253a870e421c3aa5
Ancestor: 3a615f781139bb1a1f48cfd4e27eb1d32e85f650
Author: markdoliner at pidgin.im
Date: 2009-03-27T09:36:38
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/6c9e5e620e4f484c5665cf27253a870e421c3aa5

Modified files:
        libpurple/protocols/jabber/xdata.c

ChangeLog: 

Fix a potential memleak by freeing this regardless of whether hasActions
is set

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/xdata.c	0efc19d281b56879c2f923806242f9b5084721c8
+++ libpurple/protocols/jabber/xdata.c	8a5932c63357dd2e319c0d656e607e7554566637
@@ -153,11 +153,12 @@ static void jabber_x_data_ok_cb(struct j
 	}
 	g_free(data);
 
-	if (hasActions) {
+	if (hasActions)
 		cb(js, result, actionhandle, user_data);
-		g_free(actionhandle);
-	} else
+	else
 		((jabber_x_data_cb)cb)(js, result, user_data);
+
+	g_free(actionhandle);
 }
 
 static void jabber_x_data_cancel_cb(struct jabber_x_data_data *data, PurpleRequestFields *fields) {


More information about the Commits mailing list