pidgin: 23c34d2f: Add missing null sentinels, and help the...

sadrul at pidgin.im sadrul at pidgin.im
Thu Oct 8 00:02:20 EDT 2009


-----------------------------------------------------------------
Revision: 23c34d2f91f96690dc97b8baeea95f88b0271112
Ancestor: 834bb4ff0e4888f70c027426a0beca90285fa5b2
Author: sadrul at pidgin.im
Date: 2009-10-07T21:17:10
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/23c34d2f91f96690dc97b8baeea95f88b0271112

Modified files:
        finch/gntblist.c finch/libgnt/gntbindable.h
        finch/libgnt/gntentry.c

ChangeLog: 

Add missing null sentinels, and help the compiler catch such errors.

-------------- next part --------------
============================================================
--- finch/gntblist.c	6af88c34f707757281dacf43b3e4ea0e23fa4549
+++ finch/gntblist.c	0064525c2078fc90cffe446b196b81763b6dd3e7
@@ -1940,7 +1940,7 @@ key_pressed(GntWidget *widget, const cha
 	} else if (!gnt_tree_is_searching(GNT_TREE(ggblist->tree))) {
 		if (strcmp(text, "t") == 0) {
 			finch_blist_toggle_tag_buddy(gnt_tree_get_selection_data(GNT_TREE(ggblist->tree)));
-			gnt_bindable_perform_action_named(GNT_BINDABLE(ggblist->tree), "move-down");
+			gnt_bindable_perform_action_named(GNT_BINDABLE(ggblist->tree), "move-down", NULL);
 		} else if (strcmp(text, "a") == 0) {
 			finch_blist_place_tagged(gnt_tree_get_selection_data(GNT_TREE(ggblist->tree)));
 		} else
============================================================
--- finch/libgnt/gntbindable.h	f7bcdb12cc86496846cca806a94fa5c6eff21a99
+++ finch/libgnt/gntbindable.h	fb369dc759763952f6dcddce5badb756c5c37247
@@ -166,7 +166,7 @@ gboolean gnt_bindable_check_key(GntBinda
  *
  * @return  @c TRUE if the action was performed successfully, @c FALSE otherwise.
  */
-gboolean gnt_bindable_perform_action_named(GntBindable *bindable, const char *name, ...);
+gboolean gnt_bindable_perform_action_named(GntBindable *bindable, const char *name, ...) G_GNUC_NULL_TERMINATED;
 
 /**
  * Returns a GntTree populated with "key" -> "binding" for the widget.
============================================================
--- finch/libgnt/gntentry.c	4610b8252b64d4d03f882f740359a263d6650526
+++ finch/libgnt/gntentry.c	460cc9d3e71a622f63bb23b0cad0717d4cefa160
@@ -495,7 +495,7 @@ suggest_show(GntBindable *bind, GList *n
 {
 	GntEntry *entry = GNT_ENTRY(bind);
 	if (entry->ddown) {
-		gnt_bindable_perform_action_named(GNT_BINDABLE(entry->ddown), "move-down");
+		gnt_bindable_perform_action_named(GNT_BINDABLE(entry->ddown), "move-down", NULL);
 		return TRUE;
 	}
 	return show_suggest_dropdown(entry);


More information about the Commits mailing list