pidgin: d184480b: Fix a crash on receiving a file with no ...

qulogic at pidgin.im qulogic at pidgin.im
Sun Dec 19 17:45:32 EST 2010


----------------------------------------------------------------------
Revision: d184480b5fe508c3817048b425059a03a127bef5
Parent:   3503bcedab234dbe068617fb1fc3916bf46eb33a
Author:   qulogic at pidgin.im
Date:     12/19/10 15:30:38
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/d184480b5fe508c3817048b425059a03a127bef5

Changelog: 

Fix a crash on receiving a file with no preview that I just introduced
with the new functions. The preview pointer/size was left
uninitialized if there wasn't one.

Changes against parent 3503bcedab234dbe068617fb1fc3916bf46eb33a

  patched  libpurple/protocols/msn/xfer.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/xfer.c	75eb0983c0370be20175eb8643b71174e50a5309
+++ libpurple/protocols/msn/xfer.c	d9d638d190006a728e951e8d179a054d5d7b2d0d
@@ -225,6 +225,9 @@ msn_file_context_from_wire(const char *b
 	if (header->type == 0 && len > header->length) {
 		header->preview_len = len - header->length;
 		header->preview = g_memdup(buf, header->preview_len);
+	} else {
+		header->preview_len = 0;
+		header->preview = NULL;
 	}
 
 	return header;


More information about the Commits mailing list