pidgin: 64a10252: oscar: Plug two leaks in peer_proxy code

darkrain42 at pidgin.im darkrain42 at pidgin.im
Tue Dec 28 01:06:15 EST 2010


----------------------------------------------------------------------
Revision: 64a1025212ce1088c4627afd68bf36976eda2946
Parent:   2fed8454b4b8c230e50baa091723fa2f28462b85
Author:   darkrain42 at pidgin.im
Date:     12/28/10 01:01:41
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/64a1025212ce1088c4627afd68bf36976eda2946

Changelog: 

oscar: Plug two leaks in peer_proxy code

==32109== 41 bytes in 1 blocks are definitely lost in loss record 9,232 of 18,342
==32109==    at 0x4C244E8: malloc (vg_replace_malloc.c:236)
==32109==    by 0x90D8534: g_malloc (gmem.c:132)
==32109==    by 0x1613A4F0: byte_stream_new (bstream.c:32)
==32109==    by 0x1615D3F5: peer_proxy_connection_established_cb (peer_proxy.c:76)
==32109==    by 0x93F754B: purple_proxy_connect_data_connected (proxy.c:617)
==32109==    by 0x93F7637: socket_ready_cb (proxy.c:676)

==32109== 44 bytes in 1 blocks are definitely lost in loss record 9,263 of 18,342
==32109==    at 0x4C244E8: malloc (vg_replace_malloc.c:236)
==32109==    by 0x90D8534: g_malloc (gmem.c:132)
==32109==    by 0x1613A4F0: byte_stream_new (bstream.c:32)
==32109==    by 0x1615D2E1: peer_proxy_connection_established_cb (peer_proxy.c:112)
==32109==    by 0x93F754B: purple_proxy_connect_data_connected (proxy.c:617)
==32109==    by 0x93F7637: socket_ready_cb (proxy.c:676)

Changes against parent 2fed8454b4b8c230e50baa091723fa2f28462b85

  patched  libpurple/protocols/oscar/peer_proxy.c

-------------- next part --------------
============================================================
--- libpurple/protocols/oscar/peer_proxy.c	08d1d3abd3cc0049c3664ead88b064b9b064a5ba
+++ libpurple/protocols/oscar/peer_proxy.c	8136925bd1e63d8f3e315c5e34dd2a29110b6ebf
@@ -83,6 +83,8 @@ peer_proxy_send_create_new_conn(PeerConn
 	byte_stream_putcaps(&frame.payload, conn->type); /* Value */
 
 	peer_proxy_send(conn, &frame);
+
+	byte_stream_destroy(&frame.payload);
 }
 
 /**
@@ -120,6 +122,8 @@ peer_proxy_send_join_existing_conn(PeerC
 	byte_stream_putcaps(&frame.payload, conn->type); /* Value */
 
 	peer_proxy_send(conn, &frame);
+
+	byte_stream_destroy(&frame.payload);
 }
 
 /**


More information about the Commits mailing list