pidgin: 6e71d7a1: oscar: Fix a memleak on receipt of messa...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Tue Dec 28 01:06:15 EST 2010


----------------------------------------------------------------------
Revision: 6e71d7a1e310cbb6c06b36dfbfc0a3120e8a31af
Parent:   8febed9408d870efdef757d67f9a3631e1d6d494
Author:   darkrain42 at pidgin.im
Date:     12/28/10 00:54:04
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/6e71d7a1e310cbb6c06b36dfbfc0a3120e8a31af

Changelog: 

oscar: Fix a memleak on receipt of messages

==32109== 2,981 bytes in 7 blocks are definitely lost in loss record 18,095 of 18,342
==32109==    at 0x4C244E8: malloc (vg_replace_malloc.c:236)
==32109==    by 0x90D8534: g_malloc (gmem.c:132)
==32109==    by 0x1613A408: byte_stream_getstr (bstream.c:167)
==32109==    by 0x161434B3: incomingim (family_icbm.c:928)
==32109==    by 0x161440A4: snachandler (family_icbm.c:2112)
==32109==    by 0x1614B4D2: flap_connection_recv (flap_connection.c:776)

Changes against parent 8febed9408d870efdef757d67f9a3631e1d6d494

  patched  libpurple/protocols/oscar/family_icbm.c

-------------- next part --------------
============================================================
--- libpurple/protocols/oscar/family_icbm.c	1594691e4c4a4d304a284013e9b9c58558db046b
+++ libpurple/protocols/oscar/family_icbm.c	8db064a7666ce65d7c90012a8c19204c7a6ed03f
@@ -927,6 +927,7 @@ incomingim_ch1_parsemsg(OscarData *od, a
 
 			msg = byte_stream_getstr(message, msglen);
 			args->msg = oscar_decode_im(account, userinfo->bn, charset, msg, msglen);
+			g_free(msg);
 		} else {
 			byte_stream_advance(message, length);
 		}


More information about the Commits mailing list