pidgin: 2435c5d7: jabber: Comment the problematic behavior...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Sun Sep 19 23:40:41 EDT 2010


----------------------------------------------------------------------
Revision: 2435c5d7fda0939940d68dc84d697b1fb5659bd9
Parent:   9bb423c075e503083363981f5e96b3ad800182fd
Author:   darkrain42 at pidgin.im
Date:     09/19/10 23:25:12
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/2435c5d7fda0939940d68dc84d697b1fb5659bd9

Changelog: 

jabber: Comment the problematic behavior of jabber_add_(feature|identity)

Changes against parent 9bb423c075e503083363981f5e96b3ad800182fd

  patched  libpurple/protocols/jabber/jabber.h

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/jabber.h	2ed2f631148edf60e6833338cbc4b377d6dbe99a
+++ libpurple/protocols/jabber/jabber.h	8093864e192c0e6f0cc8f19f0bb91a7a19ea77c2
@@ -338,11 +338,25 @@ char *jabber_parse_error(JabberStream *j
  */
 char *jabber_parse_error(JabberStream *js, xmlnode *packet, PurpleConnectionError *reason);
 
-void jabber_add_feature(const gchar *namespace, JabberFeatureEnabled cb); /* cb may be NULL */
+/**
+ * Add a feature to the list of features advertised via disco#info.  If you
+ * call this while accounts are connected, Bad Things(TM) will happen because
+ * the Entity Caps hash will be out-of-date (which should be fixed :/)
+ *
+ * @param namespace The namespace of the feature
+ * @param cb        A callback determining whether or not this feature
+ *                  will advertised; may be NULL.
+ */
+void jabber_add_feature(const gchar *namespace, JabberFeatureEnabled cb);
 void jabber_remove_feature(const gchar *namespace);
 
-/** Adds an identity to this jabber library instance. For list of valid values visit the
- *	website of the XMPP Registrar ( http://www.xmpp.org/registrar/disco-categories.html#client ).
+/** Adds an identity to this jabber library instance. For list of valid values
+ * visit the website of the XMPP Registrar
+ * (http://www.xmpp.org/registrar/disco-categories.html#client).
+ *
+ * Like with jabber_add_feature, if you call this while accounts are connected,
+ * Bad Things will happen.
+ *
  *  @param category the category of the identity.
  *  @param type the type of the identity.
  *  @param language the language localization of the name. Can be NULL.


More information about the Commits mailing list