/pidgin/main: d8de636e63df: Fix for AIM when using gateway proxies

Youness Alaoui kakaroto at kakaroto.homelinux.net
Wed Oct 14 22:32:26 EDT 2015

Changeset: d8de636e63df5fc99f22b5574236381800fc27af
Author:	 Youness Alaoui <kakaroto at kakaroto.homelinux.net>
Date:	 2015-10-14 19:32 -0700
Branch:	 release-2.x.y
URL: https://hg.pidgin.im/pidgin/main/rev/d8de636e63df


Fix for AIM when using gateway proxies

The issue here is that smoe gateway proxies (such as smarsh.com) will
terminate a connection to some services (such as the BART service in
the case with the Smarsh proxy) at which point the flap_connection gets
scheduled for termination and will then check if there are any LOCATE
services connections available, if there are none, it will sign out.
The problem is that the flap_connection_getbytype call will only return
connections that are 'connected' (passed auth) but since the MD5 authentication
method, it never sets any connection to connected, so it thinks there are
no LOCATE connections and signs out.
This should fix other bugs that might be affected by the API call
flap_connection_getbytype returning NULL when it shouldn't.
This should fix issue #14917 : https://developer.pidgin.im/ticket/14917

Reviewed by: Jorge Villase?or <salinasv at pidgin.im>
Backported from default


 libpurple/protocols/oscar/oscar.c |  1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diffs (11 lines):

diff --git a/libpurple/protocols/oscar/oscar.c b/libpurple/protocols/oscar/oscar.c
--- a/libpurple/protocols/oscar/oscar.c
+++ b/libpurple/protocols/oscar/oscar.c
@@ -548,6 +548,7 @@ flap_connection_established_bart(OscarDa
 static int
 flap_connection_established(OscarData *od, FlapConnection *conn, FlapFrame *fr, ...)
+	conn->conn = TRUE;
 	purple_debug_info("oscar", "FLAP connection of type 0x%04hx is "
 			"now fully connected\n", conn->type);
 	if (conn->type == SNAC_FAMILY_LOCATE)

More information about the Commits mailing list