Revision 45acf7a629de79f67b489f696c7915cd9984f33e

[Richard Laager]

On Sat, 2007-04-28 at 08:49 -0400, Stu Tomlinson wrote:
> On Fri, 2007-04-27 at 23:04 -0400, rlaager at pidgin.im wrote:
> > To get the patch for this revision, please do this:
> > mtn log --last 1 --diffs --from 45acf7a629de79f67b489f696c7915cd9984f33e
> 
> o   -----------------------------------------------------------------
> |   Revision: 45acf7a629de79f67b489f696c7915cd9984f33e
> |   Ancestor: cf51292b9bf12554eecb319a673f153ef5c6f0e4
> |   Author: rlaager at pidgin.im
> |   Date: 2007-04-28T02:29:43
> |   Branch: im.pidgin.pidgin
> |
> |   Modified files:
> |           libpurple/buddyicon.c
> |
> |   ChangeLog:
> |
> |   disapproval of revision 'cf51292b9bf12554eecb319a673f153ef5c6f0e4'
> 
> Why was this revision disapproved? It prevents a crash migrating buddy
> icons on some platforms when there are zero length files in
> ~/.gaim/icons

See revision ee5fc52ab6b3aeb9bcd34f54329b30ff5a71ba6f which fixes the
only case where purple_buddy_icon_data_calculate_filename() could be
called with (icon_data == NULL || icon_len <= 0) which is necessary to
get purple_util_get_image_extension() to return the problematic NULL.

Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20070428/6e5f54b3/attachment.sig>