Revision 45acf7a629de79f67b489f696c7915cd9984f33e

Stu Tomlinson stu at nosnilmot.com
Sat Apr 28 16:02:33 EDT 2007


> > Why was this revision disapproved? It prevents a crash migrating buddy
> > icons on some platforms when there are zero length files in
> > ~/.gaim/icons
> 
> See revision ee5fc52ab6b3aeb9bcd34f54329b30ff5a71ba6f which fixes the
> only case where purple_buddy_icon_data_calculate_filename() could be
> called with (icon_data == NULL || icon_len <= 0) which is necessary to
> get purple_util_get_image_extension() to return the problematic NULL.

Except that it isn't the only case because I had the same thing again
when I re-tested this afternoon:

g_log: purple_util_get_image_extension: assertion `len > 0' failed
buddyicon: Error writing /home/stu/.purple/icons/da39a3ee5e6b4b0d3255bfef95601890afd80709.(null): No such file or directory

$ ls -l .purple/icons/*.\(null\)
-rw-rw-r--  1 stu stu 0 Apr 27 16:03 .purple/icons/da39a3ee5e6b4b0d3255bfef95601890afd80709.(null)

Regards,


Stu.




More information about the Devel mailing list