5ac064e7: Attention API for nudges/buzzes/zaps of …

Sadrul Habib Chowdhury imadil at gmail.com
Sun Aug 26 03:34:32 EDT 2007


* jeff2 at soc.pidgin.im had this to say on [26 Aug 2007, 03:15:15 -0400]:
[snip]
> 
> ChangeLog: 
> 
> Attention API for nudges/buzzes/zaps of various protocols.
> (This API addition can now be committed since it we're in 2.2.0.)
> 
> Patch also available at http://msimprpl.darkthoughts.net/attention3.diff.
> Closes #2662.
> 

[snip]
> +
> +		plugin_return = GPOINTER_TO_INT(
> +			purple_signal_emit_return_1(purple_conversations_get_handle(),
> +									  "receiving-im-msg", gc->account,
> +									  &who_copy, &attn, conv));
> +
> +		if (!attn || !who_copy || plugin_return) {
> +			g_free(who_copy);
> +			return;
> +		}
> +
> +		purple_signal_emit(purple_conversations_get_handle(), "received-im-msg", gc->account,
> +						 who, attn, conv);
> +	}
> +

The signatures of the signals here are wrong. The receiving- signal
callback expects

(PurpleAccount*, char **, char **, PurpleConversation *, PurpleMessageFlags *)
	
But here, it sends

(PurpleAccount*, char **, PurpleAttentionType **, PurpleConversation *)

Note the difference in the third parameter, and in the number of
parameters.

Sadrul



More information about the Devel mailing list