[PATCH] SILC prpl ported to SILC Toolkit 1.1

Stu Tomlinson stu at nosnilmot.com
Sun Jun 3 12:19:12 EDT 2007

On Sun, 2007-06-03 at 09:27 +0200, Pekka Riikonen wrote:
> On Sat, 2 Jun 2007, Mark Doliner wrote:
> : I'm afraid that requiring a newer version makes more work for 
> : distributions that package libpurple, because they'll either have to 
> : upgrade silc or temporarily stop providing the silc prpl.
> : 
> There are quite a few changes in the Client Library API which would cause 
> the code to be littered with #ifdef's if we want to preserve support for 
> the Toolkit 1.0.  I did not do this, but certainly it is not impossible to 
> do.

Would it be preferable to maintain two prpls for SILC in libpurple, one
that uses Toolkit 1.0 and one that uses Toolkit 1.1 ?

One thing I noticed in the patch that I don't like is this:

  /* If the channel is not on buddy list, automatically add it there. */

I don't think simply joining a channel should add it to the buddy list,
but I may be misreading the patch.



More information about the Devel mailing list