Fwd: pidgin, irc, whois_info and non-english usernames

[Daniel Atallah]

I'm not sure why this was sent to me directly.

-D

---------- Forwarded message ----------
From: FluDeR <fluder.tw at gmail.com>
Date: Nov 29, 2007 10:18 AM
Subject: pidgin, irc, whois_info and non-english usernames
To: datallah at pidgin.im


Hello!

I found one bug in pidgin: when I do whois on some user, that has
non-english name, I can't see his userhost.

I think that is becouse we don't convert his name (arg[2]) to utf8 and
appending it to userhost (%s@%s, argv[2], argv[3])

This patch helps me:


*** libpurple-protocols-irc-parse.c.orig        2007-11-29 18:09:
33.000000000 +0200
--- libpurple-protocols-irc-parse.c     2007-11-29 18:10:31.000000000 +0200
*************** static struct _irc_msg {
*** 64,70 ****
        { "318", "nt:", irc_msg_endwhois },     /* End of
WHOIS                 */
        { "319", "nn:", irc_msg_whois },        /* Whois
channels               */
        { "320", "nn:", irc_msg_whois },        /* Whois (fn
ident)             */
!       { "314", "nnvvv:", irc_msg_whois },     /* Whowas
user                  */
        { "369", "nt:", irc_msg_endwhois },     /* End of
WHOWAS                */
        { "321", "*", irc_msg_list },           /* Start of
list                */
        { "322", "ncv:", irc_msg_list },        /*
List.                        */
--- 64,70 ----
        { "318", "nt:", irc_msg_endwhois },     /* End of
WHOIS                 */
        { "319", "nn:", irc_msg_whois },        /* Whois
channels               */
        { "320", "nn:", irc_msg_whois },        /* Whois (fn
ident)             */
!       { "314", "nnnvv:", irc_msg_whois },     /* Whowas
user                  */
        { "369", "nt:", irc_msg_endwhois },     /* End of
WHOWAS                */
        { "321", "*", irc_msg_list },           /* Start of
list                */
        { "322", "ncv:", irc_msg_list },        /*
List.                        */
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20071129/90b110c2/attachment.html>