Fwd: pidgin, irc, whois_info and non-english usernames

Ethan Blanton elb at pidgin.im
Thu Nov 29 10:43:10 EST 2007


Daniel Atallah spake unto us the following wisdom:
> FluDeR wrote:
> > I found one bug in pidgin: when I do whois on some user, that has
> > non-english name, I can't see his userhost.
> > 
> > I think that is becouse we don't convert his name (arg[2]) to utf8 and
> > appending it to userhost (%s@%s, argv[2], argv[3])
>
> I'm not sure why this was sent to me directly.

-       { "314", "nnvvv:", irc_msg_whois },     /* Whowas
+       { "314", "nnnvv:", irc_msg_whois },     /* Whowas

It's surprising to me that *usernames* are non-ASCII, but I'm not
surprised that servers aren't checking fo this.  This change looks
reasonable to me, and I will apply it.

Ethan

-- 
The laws that forbid the carrying of arms are laws [that have no remedy
for evils].  They disarm only those who are neither inclined nor
determined to commit crimes.
		-- Cesare Beccaria, "On Crimes and Punishments", 1764
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20071129/d38e51a1/attachment.sig>


More information about the Devel mailing list