im.pidgin.pidgin: 63a37bce425022f4c52fab82e7169ed73f50a49e

[Etan Reisner]

On Tue, Oct 16, 2007 at 03:26:03AM -0400, markdoliner at pidgin.im wrote:
<snip>
> ============================================================
> --- libpurple/dbus-server.c	d95604bc588db428fb05bff965a1bdce89dd6c3b
> +++ libpurple/dbus-server.c	6452b12fec6bcb52b434ae76bc1dd199b6dd96fd
> @@ -674,6 +674,8 @@ purple_dbus_message_append_purple_values
>  		int id;
>  		gint xint;
>  		guint xuint;
> +		gint64 xint64;
> +		guint64 xuint64;
>  		gboolean xboolean;
>  		gpointer ptr = NULL;
>  		gpointer val;
> @@ -694,6 +696,14 @@ purple_dbus_message_append_purple_values
>  			xuint = my_arg(guint);
>  			dbus_message_iter_append_basic(iter, DBUS_TYPE_UINT32, &xuint);
>  			break;
> +		case PURPLE_TYPE_INT64:
> +			xint = my_arg(gint64);
> +			dbus_message_iter_append_basic(iter, DBUS_TYPE_INT64, &xint);

Shouldn't this be:
    xint64 = my_arg(gint64);
    dbus_message_iter_append_basic(iter, DBUS_TYPE_INT64, &xint64);

> +			break;
> +		case PURPLE_TYPE_UINT64:
> +			xuint = my_arg(guint64);
> +			dbus_message_iter_append_basic(iter, DBUS_TYPE_UINT64, &xuint);

And this:
    xuint64 = my_arg(guint64);
    dbus_message_iter_append_basic(iter, DBUS_TYPE_UINT64, &xuint64);

> +			break;
>  		case PURPLE_TYPE_BOOLEAN:
>  			xboolean = my_arg(gboolean);
>  			dbus_message_iter_append_basic(iter, DBUS_TYPE_BOOLEAN, &xboolean);

	-Etan (Who is at work and can't commit things.)