Revision 0d182c079b200633b234b9a8216aba155384f21b

[Richard Laager]

On Sat, 2007-09-08 at 20:50 -0400, khc at pidgin.im wrote:
> -----------------------------------------------------------------
> Revision: 0d182c079b200633b234b9a8216aba155384f21b
> Ancestor: 339e17f432d068c87ce9aaa8d19e6f271d1101b1
> Author: khc at pidgin.im
> Date: 2007-09-09T00:46:16
> Branch: im.pidgin.cpw.khc.msnp14
> 
> Modified files:
>         libpurple/protocols/msn/oim.c
> 
> ChangeLog: 
> 
> I think this is the right way to fix timezone. People on Win32 _and_
> people on system without HAVE_TM_GMTOFF and with HAVE_TIMEZONE need to
> test this
> 
> Everyone else test this too, because I didn't

I wondered what was going on here, so I got to looking... From the code:

/* like purple_str_to_time, but different. The format of the timestamp
 * is like this: 5 Sep 2007 21:42:12 -0700 */
static time_t
msn_oim_parse_timestamp(const char *timestamp)

Is there some reason that purple_str_to_time() couldn't be extended to
accept that format? If not, then is your timezone code a direct
copy-and-paste from that function? If so, could we abstract that portion
out into an internal function? If nothing else, you can at least compare
your code to that function if you haven't already (and I don't mean to
suggest that you didn't--I didn't look at the code closely).

Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20070908/c570d052/attachment.sig>