pidgin: ae37fe6b: Added "chat-join-failed" signal, emitted...
John Bailey
rekkanoryo at rekkanoryo.org
Mon Apr 28 22:24:28 EDT 2008
evands at pidgin.im wrote:
> ChangeLog:
>
> Added "chat-join-failed" signal, emitted by a new serv_got_join_chat_failed()
> function in server.c. This is emitted with the PurpleConnection and
> chat name and allows a UI or plugin which was expecting a group chat to be
> joined to know if failure occurred.
>
> serv_got_join_chat_failed() is only called by jabber so far; I know that
> at least oscar should call it some situations, as well, such as when a
> busted SNAC error is received after trying to join a chat with an invalid
> room name.
This addition of API and a signal forces us to version 2.5.0. While I have no
issues with bumping our version number, I am curious why this is needed and what
benefit it gives us. Also, do we want to force 2.5.0 now? If so, I think
Sadrul wants to merge the custom smiley stuff.
John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20080428/9a2da3b7/attachment.sig>
More information about the Devel
mailing list