Fwd: Re: request modification to configure.ac

[Bill Fassler]

Oops just realized I responded directly to Stu instead of the devel at pidgin.im

Bill Fassler <bill.fassler at yahoo.com> wrote: Date: Tue, 26 Feb 2008 12:50:28 -0800 (PST)
From: Bill Fassler <bill.fassler at yahoo.com>
Subject: Re: request modification to configure.ac
To: Stu Tomlinson <stu at nosnilmot.com>

 I have to swap the order of the lines and add the dependency. Hopefully the patch will make it easier to see what I mean.  I can't imagine this adversely affecting the mainstream desktop users of pidgin or finch, but I haven't verified this.

Bill

Stu Tomlinson <stu at nosnilmot.com> wrote: On Tue, 2008-02-26 at 12:07 -0800, Bill Fassler wrote:
> Even with the newest pidgin release I continue have to manually modify
> your configure.ac file in order to ensure that -lpanel preceeds
> -lncurses during linking.  You folks helped me identify this issue the
> first time I encountered it so I am wondering if this change affects
> the mainstream users?  If not would you considering making this change
> in future releases?
> 
>     AC_CHECK_LIB(panelw, update_panels,  [GNT_LIBS="$GNT_LIBS
> -lpanelw"], [enable_consoleui=no], [-lncursesw])
>     AC_CHECK_LIB(ncursesw, initscr, [GNT_LIBS="$GNT_LIBS -lncursesw"],
> [enable_consoleui=no])
> 
> and
> 
>                 AC_CHECK_LIB(panel, update_panels,
> [GNT_LIBS="$GNT_LIBS -lpanel"], [enable_consoleui=no], [-lncurses])
>         AC_CHECK_LIB(ncurses, initscr, [GNT_LIBS="$GNT_LIBS
> -lncurses"], [enable_consoleui=no])

Is it just the order of the checks you need changing? or do you just
need the 4th argument to AC_CHECK_LIB for panel{,w}? It would be easier
to see exactly what you want changing if you can supply a patch.

Regards,


Stu.


        

---------------------------------
Looking for last minute shopping deals?   Find them fast with Yahoo! Search.--- configure.ac~ 2007-12-07 09:36:58.000000000 -0500
+++ configure.ac 2008-02-26 13:25:00.000000000 -0500
@@ -566,8 +566,8 @@
   [compile finch against the ncurses includes in DIR])],
   [ac_ncurses_includes="$withval"], [ac_ncurses_includes=""])
 if test "x$enable_consoleui" = "xyes"; then
- AC_CHECK_LIB(ncursesw, initscr, [GNT_LIBS="-lncursesw"], [enable_consoleui=no])
- AC_CHECK_LIB(panelw, update_panels, [GNT_LIBS="$GNT_LIBS -lpanelw"], [enable_consoleui=no])
+ AC_CHECK_LIB(panelw, update_panels, [GNT_LIBS="$GNT_LIBS -lpanelw"], [enable_consoleui=no], [-lncursesw])
+ AC_CHECK_LIB(ncursesw, initscr, [GNT_LIBS="$GNT_LIBS -lncursesw"], [enable_consoleui=no])
 
  if test "x$enable_consoleui" = "xyes"; then
   dnl # Some distros put the headers in ncursesw/, some don't
@@ -609,8 +609,8 @@
  else
   # ncursesw was not found. Look for plain old ncurses
   enable_consoleui=yes
-  AC_CHECK_LIB(ncurses, initscr, [GNT_LIBS="-lncurses"], [enable_consoleui=no])
-  AC_CHECK_LIB(panel, update_panels, [GNT_LIBS="$GNT_LIBS -lpanel"], [enable_consoleui=no])
+                AC_CHECK_LIB(panel, update_panels, [GNT_LIBS="$GNT_LIBS -lpanel"], [enable_consoleui=no], [-lncurses])
+  AC_CHECK_LIB(ncurses, initscr, [GNT_LIBS="$GNT_LIBS -lncurses"], [enable_consoleui=no])
   AC_DEFINE(NO_WIDECHAR, 1, [Define to 1 if you don't have wide-character support.])
   if test x"$ac_ncurses_includes" != "x"; then
    GNT_CFLAGS="-I$ac_ncurses_includes"


       
---------------------------------
Looking for last minute shopping deals?  Find them fast with Yahoo! Search.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20080226/e2385db9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.ac.patch
Type: text/x-patch
Size: 1446 bytes
Desc: pat1144294570
URL: <http://pidgin.im/pipermail/devel/attachments/20080226/e2385db9/attachment-0002.bin>