Chat

[Rafael Franco Carvalho]

Hello.

> The problem with that is, if you dis+reconnect the account and 'Initiate
> Chat' on some other buddy, an existing chat (possibly with someone else)
> may be reused, which is undesirable.

Yes Sadrul, you're right.

> >is very ugly ... I don't like either of the patches. Perhaps you can
> >find a cleaner fix? :)

I don't know libpurple very much. Maybe I'm not the better choice to make
this fix. But I think we can move your changes to switchboard.c, adding
chat_name to _MsnSwitchBoard struct and setting chat_name on
msn_switchboard_new(). So we can use swboard->chat_name on
serv_got_joined_chat() in msn.c.

Is it a good idea open new ticket for this msn multi-user chat patch?

Please, let me know if you do more changes on your patches.

Thanks.


Rafael Franco Carvalho
Technology and Quality on Information

* + 55 34 3291 1700	
* + 55 34 9145-2495	
* rafael.carvalho at tqi.com.br	
* www.tqi.com.br	

-----Original message-----
De: Sadrul Habib Chowdhury [mailto:imadil at gmail.com] 
Enviada em: sexta-feira, 28 de dezembro de 2007 17:02
Para: Rafael Franco Carvalho
Cc: 'Sean Egan'; devel at pidgin.im
Assunto: Re: RES: RES: Chat

* Rafael Franco Carvalho had this to say on [28 Dec 2007, 16:36:49 -0200]:
> Hi Sadrul
> 
> >It looks like we always try to create a chat with the same name ('MSN
> >Chat'), which confuses purple. The fix would be to create a chat with a
> >different name each time. Either of the attached patches will work
> >around the bug on most occasions, I think. But I am not sure how the
> >change in server.c will affect the other prpls, and the change in msn.c
> >is very ugly ... I don't like either of the patches. Perhaps you can
> >find a cleaner fix? :)
> >
> >Sadrul
> 
> I think we can use chat_id instead of another counter on msn.c. Something
> like this:
> 

The problem with that is, if you dis+reconnect the account and 'Initiate
Chat' on some other buddy, an existing chat (possibly with someone else)
may be reused, which is undesirable.

> 
> There are a "MSN Chat" on switchboard.c at msn_switchboard_add_user(), we
> have to do the same thing that msn.c, I guess.

Possibly.

Sadrul