[PATCH] Make "mtn log" show the signer of changelog/comment certs

Richard Laager rlaager at wiktel.com
Sat Jan 5 12:47:42 EST 2008


The Pidgin project has been using --author to credit patch submitters.
Currently, though, it's not very easy to tell who committed the revision
when looking at log messages. I also find it odd to see a patch with an
author of "Bob" and a changelog message of "A patch from Bob that does
[blah]. I modified this a bit, ....". Additionally, you can't easily
tell who used "mtn comment".

The attached patch solves these three issues by displaying the signer of
the cert when the cert is multiline. This is currently only the case for
changelog and comment certs. I think this behavior is likely to be
desired if further multiline certs were added to the log output. Plus,
the function I modified is internal to this file anyway.

Richard

Here's an example the change; it's just the ChangeLog line that differs:

o   -----------------------------------------------------------------
|   Revision: 1666e4ac675420b25c9763e9e38caac93d16c5b0
|   Ancestor: fc87a0a058f0e03b2193c74fe82ebeb51532576e
|   Author: iwasroot at gmail.com
|   Date: 2008-01-05T16:32:40
|   Branch: im.pidgin.pidgin
|   
|   Modified files:
|           COPYRIGHT ChangeLog pidgin/gtkconv.c
|   
|   ChangeLog: 
|   
|   Save the conversation "Enable Logging" option per-contact.

vs.

o   -----------------------------------------------------------------
|   Revision: 1666e4ac675420b25c9763e9e38caac93d16c5b0
|   Ancestor: fc87a0a058f0e03b2193c74fe82ebeb51532576e
|   Author: iwasroot at gmail.com
|   Date: 2008-01-05T16:32:40
|   Branch: im.pidgin.pidgin
|   
|   Modified files:
|           COPYRIGHT ChangeLog pidgin/gtkconv.c
|   
|   ChangeLog (by rlaager at pidgin.im):
|   
|   Save the conversation "Enable Logging" option per-contact.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mtn-show-signer-on-multiline-certs-in-logs.diff
Type: text/x-patch
Size: 1202 bytes
Desc: not available
URL: <http://pidgin.im/pipermail/devel/attachments/20080105/1b0f56ff/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20080105/1b0f56ff/attachment.sig>


More information about the Devel mailing list