[Monotone-devel] [PATCH] Make "mtn log" show the signer of changelog/comment certs

[Hugo Cornelis]

Any chance this patch can be extended such that

1. the signers of all certs are shown,
2. yet, only when an appropriate command line option has been given.

Point 1 seems just logical to me: if it is easy to find the signer of
one cert, then it should be easy to find out the signer of any cert.
Point 2 is about ease of use and avoiding confusing: for single person
repositories, don't show what is redundant.


Hugo


On Jan 5, 2008 12:47 PM, Richard Laager <rlaager at wiktel.com> wrote:
> The Pidgin project has been using --author to credit patch submitters.
> Currently, though, it's not very easy to tell who committed the revision
> when looking at log messages. I also find it odd to see a patch with an
> author of "Bob" and a changelog message of "A patch from Bob that does
> [blah]. I modified this a bit, ....". Additionally, you can't easily
> tell who used "mtn comment".
>
> The attached patch solves these three issues by displaying the signer of
> the cert when the cert is multiline. This is currently only the case for
> changelog and comment certs. I think this behavior is likely to be
> desired if further multiline certs were added to the log output. Plus,
> the function I modified is internal to this file anyway.
>
> Richard
>
> Here's an example the change; it's just the ChangeLog line that differs:
>
> o   -----------------------------------------------------------------
> |   Revision: 1666e4ac675420b25c9763e9e38caac93d16c5b0
> |   Ancestor: fc87a0a058f0e03b2193c74fe82ebeb51532576e
> |   Author: iwasroot at gmail.com
> |   Date: 2008-01-05T16:32:40
> |   Branch: im.pidgin.pidgin
> |
> |   Modified files:
> |           COPYRIGHT ChangeLog pidgin/gtkconv.c
> |
> |   ChangeLog:
> |
> |   Save the conversation "Enable Logging" option per-contact.
>
> vs.
>
> o   -----------------------------------------------------------------
> |   Revision: 1666e4ac675420b25c9763e9e38caac93d16c5b0
> |   Ancestor: fc87a0a058f0e03b2193c74fe82ebeb51532576e
> |   Author: iwasroot at gmail.com
> |   Date: 2008-01-05T16:32:40
> |   Branch: im.pidgin.pidgin
> |
> |   Modified files:
> |           COPYRIGHT ChangeLog pidgin/gtkconv.c
> |
> |   ChangeLog (by rlaager at pidgin.im):
> |
> |   Save the conversation "Enable Logging" option per-contact.
>
>
> _______________________________________________
> Monotone-devel mailing list
> Monotone-devel at nongnu.org
> http://lists.nongnu.org/mailman/listinfo/monotone-devel
>
>



-- 
                    Hugo Cornelis Ph.D.

                  Research Imaging Center
   University of Texas Health Science Center at San Antonio
                    7703 Floyd Curl Drive
                 San Antonio, TX  78284-6240

                    Phone: 210 567 8112
                      Fax: 210 567 8152