im.pidgin.pidgin: 04e7d54475c3ddf91ad523e3e58521bc4fa59c85

Will Thompson will at willthompson.co.uk
Thu Jan 31 07:00:40 EST 2008


On Thu, Jan 31, 2008 at 01:38:15PM +0200, Felipe Contreras wrote:
> 2008/1/31 Will Thompson <will at willthompson.co.uk>:
> > On Wed, Jan 30, 2008 at 09:31:08PM -0500, ecoffey at soc.pidgin.im wrote:
> > > For the next minor bump would be useful to add getters for gc->flags and gc->wants_to_die.
> >
> > PurpleConnection.wants_to_die is in theory obsolete, in favour of the
> > PurpleConnectionError stuff.  I think the only place still using it is
> > the new account registration code; does anyone feel like fixing up that
> > code not to do so?
> 
> These emails are not useful without some kind of reference to what is
> the change.

I assume that the kind of people who would be into messing with
wants_to_die would be the same kind of people who would subscribe to
commits@, or would have a local monotone checkout, or could just look up
the revision ID in the developer.pidgin.im ViewMTN (except that dpi is
bustified).

In this case, the context, copied below, wasn't actually important.

On Wed, Jan 30, 2008 at 09:31:08PM -0500, ecoffey at soc.pidgin.im wrote:
> -----------------------------------------------------------------
> Revision: 04e7d54475c3ddf91ad523e3e58521bc4fa59c85
> Ancestor: ae7f8e3acb446776f833c3b44514295ae56184b3
> Author: ecoffey at soc.pidgin.im
> Date: 2008-01-31T02:23:55
> Branch: im.pidgin.pidgin
> 
> Modified files:
>         libpurple/account.c
> 
> ChangeLog: 
> 
> Made account.c use purple_connection_get_prpl instead of gc->prpl.
> 
> For the next minor bump would be useful to add getters for gc->flags and gc->wants_to_die.
> 
> This was done with the blessing of rekkanoryo.

-- 
Will
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20080131/c0d3ac14/attachment.sig>


More information about the Devel mailing list