im.pidgin.pidgin: 04e7d54475c3ddf91ad523e3e58521bc4fa59c85

[Eoin Coffey]

2008/1/31 Will Thompson <will at willthompson.co.uk>:

> On Wed, Jan 30, 2008 at 09:31:08PM -0500, ecoffey at soc.pidgin.im wrote:
> > For the next minor bump would be useful to add getters for gc->flags and
> gc->wants_to_die.
>
> PurpleConnection.wants_to_die is in theory obsolete, in favour of the
> PurpleConnectionError stuff.  I think the only place still using it is
> the new account registration code; does anyone feel like fixing up that
> code not to do so?
>
> --
> Will
> Simon:  Oh!
> Kaylee: Now, this would be the perfect time for a swear word.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHobG2oIft9qPjwIsRAhoKAKDBkpj2RnY0IqRIbalCQcWUe8pgXACfW4jn
> cvUjAQ5CPtAx6UCx2NfKWXA=
> =OYzi
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Devel mailing list
> Devel at pidgin.im
> http://pidgin.im/cgi-bin/mailman/listinfo/devel
>

The only place where I could find wants_to_die being used in libpurple
(outside of connection.c) is in purple_account_set_enabled().  The logic
there seems to be if wants_to_die is TRUE, as in the user as opted to log
out or something, then don't bother attempting to connect / disconnect.

It seems that purple_connection_error_reason() and
purple_connection_error_is_fatal() are for setting gc->wants_to_die and not
accessing it.

-Eoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20080131/1dccc9dc/attachment.html>