Fwd: monotone public key
Richard Laager
rlaager at wiktel.com
Tue Jun 10 16:25:45 EDT 2008
On Tue, 2008-06-10 at 23:14 +0800, SHiNE wrote:
> This is my public key.
I've given that key push access. As discussed previously, you may commit
the to libpurple/protocols/qq folder. Please do not commit anything to
the rest of the repository without it being reviewed first. Even within
the qq prpl, you need to follow our coding standards (for example,
don't use // style comments). The following links may be helpful:
http://developer.pidgin.im/wiki/RightThingToDo
http://developer.pidgin.im/wiki/DesignGuidelines
QuLogic made a number of fixes to your patches in the following tickets,
so please test his changes and work from there so you don't lose those
changes:
http://developer.pidgin.im/ticket/5639
http://developer.pidgin.im/ticket/5718
http://developer.pidgin.im/ticket/5818
http://developer.pidgin.im/ticket/5934
When you commit things, you can include text in the commit message to
link that commit to a ticket. If the commit is related to a ticket, use
"Refs #1234" (no quotes) in the ticket. If the ticket can be closed by
that commit, use "Fixes #1234".
So, for example, let's say you have a ticket with a big patch or
multiple patches that you're reviewing and committing separately. You
might review the first piece and commit it saying "Refs #1234". You'd
then do the same with the second. When you get to the last part, you
would do "Fixes #1234".
In your case, for example, when you commit the changes from #5639,
you'll probably do it all in one commit, so you can do "Fixes #5639".
Then, when you push that change, (after a few minutes), the ticket will
be automatically closed with a message linking to that revision.
If you have any questions, feel free to ask in #pidgin on
irc.freenode.net or xmpp:devel at conference.pidgin.im. You can also e-mail
the list at devel at pidgin.im.
You may find this helpful in learning how to use Monotone:
http://developer.pidgin.im/wiki/UsingPidginMonotone
Good luck and welcome aboard! It's great to have someone actively
working on the QQ prpl.
Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://pidgin.im/pipermail/devel/attachments/20080610/26d02f91/attachment.sig>
More information about the Devel
mailing list