missing ifdef for g_object_ref_sink call

Mark Doliner mark at kingant.net
Sat Jun 21 14:48:19 EDT 2008

On Sat, 21 Jun 2008 12:41:42 -0400, Sadrul Habib Chowdhury wrote
> On a somewhat related note: in a situation like this, do we want to
> disapprove the revision and commit the correct fix, or just fix the
> change and make a new commit? I have done the latter, in this case,
> since that involves less revision(s). I think that's a reasonable
> practice for such small changesets. But I would like to know if someone
> has any thoughts on this.

I'm in favor of just fixing the change and making a new commit, because I
think it's easier and faster, and I know we all have limited free time.


More information about the Devel mailing list