pidgin: ebc5ac66: Don't try to tell the IM network that we...

Stu Tomlinson stu at nosnilmot.com
Mon Jun 23 20:29:15 EDT 2008


On Fri, 2008-05-02 at 02:20 -0400, markdoliner at pidgin.im wrote:
> -----------------------------------------------------------------
> Revision: ebc5ac66e700f6c67e30069ee2ebd4bb61f82ec8
> Ancestor: 2a2005d1ea7113d6455687048cd66fdb825b991b
> Author: markdoliner at pidgin.im
> Date: 2008-05-02T06:15:33
> Branch: im.pidgin.pidgin
> URL: http://d.pidgin.im/viewmtn/revision/info/ebc5ac66e700f6c67e30069ee2ebd4bb61f82ec8
> 
> Modified files:
>         libpurple/idle.c
> 
> ChangeLog: 
> 
> Don't try to tell the IM network that we're not idle when we disconnect.
> This was causing a crash for me in silc when I got disconnected while
> idle.  I'm not really sure why we would want to do this... the commit
> message was "A patch from Kevin Stange that should fix some idleness
> problems with MSN and Yahoo" but I couldn't find any more info about
> that.

Maybe this is what is causing the failure to return from idle reported
to support at pidgin.im ? or maybe it's just uncovered some other
brokenness?

> ============================================================
> --- libpurple/idle.c	4c2f40738284bcb7eca06867ba0f4c3c09771d9b
> +++ libpurple/idle.c	41bbad7572d5e6af2ea72a6b39fa6651dd3cbf26
> @@ -252,7 +252,7 @@ signing_off_cb(PurpleConnection *gc, voi
>  	PurpleAccount *account;
>  
>  	account = purple_connection_get_account(gc);
> -	set_account_unidle(account);
> +	idled_accts = g_list_remove(idled_accts, account);
>  }
>  
>  static void
> _______________________________________________
> Commits mailing list
> Commits at pidgin.im
> http://pidgin.im/cgi-bin/mailman/listinfo/commits




More information about the Devel mailing list