[PATCH] Add serv_got_private_alias
Mark Doliner
mark at kingant.net
Wed Mar 12 03:29:08 EDT 2008
On Wed, 27 Feb 2008 20:23:39 -0500, Evan Schoenberg wrote
> On Feb 27, 2008, at 12:36 PM, John Bailey wrote:
>
> > purple_serv_got_private_alias() should be
> > called by the oscar prpl after this alias has been retrieved from the
> > server instead of serv_got_alias(). Now serv_got_alias() should be
> > used
> > for "public" (a.k.a. "remote") aliases only.
>
> So serv_got_alias() should be called for incoming ICQ names, but
> serv_got_private_alias() should be called for incoming AIM names.
Thanks guys. I finally got around to look at this and I'm planning on leaving
oscar the way it is. Right now it looks up the PurpleBuddy for a specific
buddy+group and calls purple_blist_alias_buddy() manually.
It does that for each buddy in each group (even if the same buddy exists in
more than one group). purple_serv_got_private_alias() sets the alias on ALL
buddies with the given name, regardless of group. So if oscar used that
function 1) it would be a little slower and 2) a buddy that exists in more
than one group would have to have the same alias everywhere.
-Mark
More information about the Devel
mailing list