pidgin: fe68f3ce: A patch from QuLogic to replace the libn...

[Stu Tomlinson]

On Fri, 2008-05-09 at 23:45 -0400, rlaager at pidgin.im wrote:
> -----------------------------------------------------------------
> Revision: fe68f3cef0f055a97a7b4425baae5c7711cfb4e7
> Ancestor: 7728b8a9608a90aafa262e4af373af38d8fa7055
> Author: rlaager at pidgin.im
> Date: 2008-05-10T03:29:15
> Branch: im.pidgin.pidgin
> URL:
> http://d.pidgin.im/viewmtn/revision/info/fe68f3cef0f055a97a7b4425baae5c7711cfb4e7
> 
> Modified files:
>         libpurple/network.c
> 
> ChangeLog: 
> 
> A patch from QuLogic to replace the libnm_glib calls with straight
> DBus
> calls.  This removes a library dependence and should be more stable,
> we hope.

Fails to build on Fedora 8, NetworkManager-0.7.0-0.6.7.svn3370.fc8:

network.c: In function 'purple_network_init':
network.c:741: error: 'NM_DBUS_SIGNAL_STATE_CHANGE' undeclared (first use in this function)
network.c:741: error: (Each undeclared identifier is reported only once
network.c:741: error: for each function it appears in.)
network.c: In function 'purple_network_uninit':
network.c:767: error: 'NM_DBUS_SIGNAL_STATE_CHANGE' undeclared (first use in this function)
make: *** [network.lo] Error 1

The #define for NM_DBUS_SIGNAL_STATE_CHANGE was removed from
NetworkManager a while ago:
http://svn.gnome.org/viewvc/NetworkManager/trunk/include/NetworkManager.h?r1=2309&r2=2345
I don't know if this means the signals necessary have changed, or if we
can just replace NM_DBUS_SIGNAL_STATE_CHANGE with "StateChange"

Also, why are we not using pkg-config to find NetworkManager headers?

Regards,


Stu.