soc.2008.vv: 8222acab: Require gstreamer-plugins-base-0.10 for ...

[Felipe Contreras]

2008/5/27 Richard Laager <rlaager at wiktel.com>:
> On Tue, 2008-05-27 at 01:10 -0400, maiku at soc.pidgin.im wrote:
>> -     PKG_CHECK_MODULES(FARSIGHT, [farsight2-0.10], [
>> +     PKG_CHECK_MODULES(FARSIGHT, [farsight2-0.10 gstreamer-0.10 gstreamer-plugins-base-0.10 libxml-2.0], [
>
> We already check for libxml-2.0 and gstreamer-0.10 separately. I don't
> like the idea of having those checks duplicated. You should probably
> move the gstreamer-plugins-base-0.10 in with gstreamer. If you want to
> require all of these for -vv support, I'd recommend you add a separate
> chunk in configure.ac to check that all of those are present and define
> HAVE_VV or something.

Actually pkg-config checks for a module and all it's dependencies,
there's no need to specify all of them.

Which makes sense, so you don't have to update your checks if they
decide to drop a dependency.

So I think HAVE_FARSIGHT is ok.

Best regards.

-- 
Felipe Contreras