soc.2008.yahoo: be8be19f: added name to COPYRIGHT (alphabetically)...
Sulabh Mahajan
sulabh.dev at gmail.com
Thu May 29 07:20:32 EDT 2008
Agreed.
To keep in mind : Better/Meaningful commit messages next time onwards.
:P
sulabh
2008/5/29 Will Thompson <will at willthompson.co.uk>:
> On 29/05/08 09:06, sulabh at soc.pidgin.im wrote:
> > Modified files:
> > COPYRIGHT libpurple/protocols/yahoo/yahoo_packet.h
> >
> > ChangeLog:
> >
> > added name to COPYRIGHT (alphabetically), trivial change in packet.h
>
> Rather than saying "trivial change in packet.h", perhaps the commit
> message could have said something like "Document guessed meanings of
> some elements of yahoo_service"? We know from the commit metadata that
> it was packet.h that was modified, but it's useful to have a summary of
> what the trivial change was. :-)
>
> (Also, my preference would have been to make the COPYRIGHT change as a
> separate commit. In case you didn't know, you can use `mtn ci file1
> file2` to only commit changes in those files, ignoring changes in other
> files.)
> --
> Will
>
>
> _______________________________________________
> Devel mailing list
> Devel at pidgin.im
> http://pidgin.im/cgi-bin/mailman/listinfo/devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20080529/5dd3aec2/attachment.html>
More information about the Devel
mailing list