pidgin.openq: 6fc65db6: 2008.10.07 - lonicerae <lonicerae(at)gma...

[Phil Hannent]

Richard Laager wrote:
> On Wed, 2008-10-22 at 12:11 -0400, csyfek at gmail.com wrote:
>> --- libpurple/protocols/qq/Makefile.am	7b58ebc44b1131d5c8d7ee3b6e731725576d7a81
>> +++ libpurple/protocols/qq/Makefile.am	a1dd9472927a1f3089b9ed4ecc3c47c6cfe0c584
>> @@ -59,6 +59,11 @@ libqq_la_LDFLAGS = -module -avoid-versio
>>  
>>  libqq_la_LDFLAGS = -module -avoid-version
>>  
>> +CURRENT_REVISION=$(shell \
>> +		 awk 'BEGIN {"grep node .hg_archival.txt" | getline rev; \
>> +		 rev=substr(rev,7,6); \
>> +		 print rev}')
>> +
> 
> This breaks the build, because I don't have a .hg_archival.txt file.
> Also, we use Monotone, not Mercurial, so I'm not sure what this is doing
> there at all. Please fix this immediately.
For a Qt based project I am working on at work I implemented:

exists(_MTN):DEFINES += BUILDREVISION=\\\"$$system(mtn automate
get_base_revision_id)\\\"
else:DEFINES += BUILDREVISION=\\\"NOT BUILT FROM SOURCE REPOSITORY\\\"

This enabled me to know exactly which build a tester was using.  It would be
cool if Pidgin and libpurple did a similar thing and displayed the version in
the about box.  This would help with verifying if people are building their own
and if they have a miss-match libpurple and pidgin.

Regards
Phil Hannent


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20081103/ba03899a/attachment.sig>