Plugin devel - registering a handler for xmpp iq - not working

[Will Thompson]

Arne König wrote:
> Michal Witkowski schrieb:
>   
>> Oh. Nice :) Still, I have a question about the "without freeing it" part. I shouldn't free 
>> it because it's done somewhere within xmlnode.h as packet is a part of xml node tree, 
>> right?
>>     
>
> Come to think of it, freeing it might actually be a good idea. Sorry.
>   

It's certainly a good idea, or else it will leak.

>> Moreover, I don't see any code which would generate a warning. AFAICS in 
>> jabber_process_packet() there is:
>> 	if(NULL == *packet)
>> 		return;
>> which just drops the further processing of the packet. I can't see any warning generation. 
>> Could you please clarify?
>>     
>
> The parser will try to free it. Hence every time you 'steal' a packet
> the debug console produces the following warning:
>
>  g_log: xmlnode_free: assertion `node != NULL' failed
>   

I've just pushed a patch (3998d5347fcf5) to fix jabber.c not to try to
free xmlnodes stolen by receiving-xmlnode handlers.

Regards,

-- 
Will


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://pidgin.im/pipermail/devel/attachments/20081121/c3217afa/attachment.sig>