pidgin: 8fef7485: This was wrong, right? How did it work?

Mark Doliner mark at kingant.net
Thu Aug 13 14:31:45 EDT 2009


This change looks correct to me.  The handle is only used when
disconnecting from the prefs, and since that wasn't happening before
it didn't really matter.

-Mark

On Wed, Aug 12, 2009 at 8:34 PM, <darkrain42 at pidgin.im> wrote:
> -----------------------------------------------------------------
> Revision: 8fef7485f0da115135b70f8f9ab709685878b4d7
> Ancestor: 4d826f39a9a7e9be09284e2f25a11f75aa9b87f1
> Author: darkrain42 at pidgin.im
> Date: 2009-08-13T01:17:04
> Branch: im.pidgin.pidgin
> URL: http://d.pidgin.im/viewmtn/revision/info/8fef7485f0da115135b70f8f9ab709685878b4d7
>
> Modified files:
>        libpurple/status.c
>
> ChangeLog:
>
> This was wrong, right? How did it work?
>
>
> ============================================================
> --- libpurple/status.c  8ae07f349706744761f523ed621c0dd0f893b861
> +++ libpurple/status.c  19fe187267281b215868b22d2ebd03fe67bb0062
> @@ -1660,7 +1660,7 @@ purple_status_init(void)
>  void
>  purple_status_init(void)
>  {
> -       void *handle = purple_status_get_handle;
> +       void *handle = purple_status_get_handle();
>
>        purple_prefs_add_none("/purple/status");
>        purple_prefs_add_none("/purple/status/scores");
> @@ -1714,4 +1714,5 @@ purple_status_uninit(void)
>  void
>  purple_status_uninit(void)
>  {
> +       purple_prefs_disconnect_by_handle(purple_prefs_get_handle());
>  }




More information about the Devel mailing list