Gadu-Gadu protocol update and patch

[Daniel Atallah]

2009/8/25 Ethan Blanton <elb at pidgin.im>:
> Tomasz Sałaciński spake unto us the following wisdom:
>> There are the four patches to Gadu-Gadu protocol in Pidgin - libgadu
>> update to 1.8.2 (this fixes a few security issues, for more info email
>> me):
>>
>> http://www.alarm-clock.pl/libgadu_1.8.2.patch
>> http://www.alarm-clock.pl/Makefile.am.patch
>
> OK, this I will treat separately.  Stu Tomlinson has mentioned that he
> believes we have a number of fixes in our private libgadu to make
> things work for win32.  I don't know the details of those fixes, or
> whether they are upstream -- at least one developer believes we passed
> them upstream, but we do not know if they were adopted even if this is
> the case.  We should find out if this updated source works on win32,
> but I am not the man to do that.  :-)

IIRC I was the one who made the fixes.  I don't remember everything
offhand, but one of the things was converting the threading to use
native win32 threads instead of pthread.

As far as I know they weren't ever submitted upstream (I think there
is an open ticket assigned to me about this).  I didn't necessarily
make an effort to make the changes non-libpurple-specific at the time
and never circled back to figure out what that would take.

>
> All things considered, I'd like to see these patches go in sooner
> rather than later.  I'd like some answers on the win32 compatability
> of the libgadu updates before that happens -- if you can check that,
> great, if not, maybe Daniel or someone could poke at it.  I'll also
> see if we can get Bartosz (our nominal gg maintainer) to take a look.

If someone creates an account for me (or I can dig up my old account
and it is still active), I can do some rudimentary testing to make
sure it still logs in in Windows, but I can't necessarily test it all
that thoroughly.

Does the patch effectively revert the in-tree libgg code to a
"vanilla" 1.8.2 version?

-D