pidgin: e9fdd89a: jabber: Strip the '/' off of a JID in ja..

Paul Aurich paul at darkrain42.org
Wed Aug 26 20:42:04 EDT 2009


And Mark Doliner spoke on 08/22/2009 04:51 PM, saying:
> Hmm, is this change ONLY needed to handle the case where our JID ends
> in a slash?  I wonder if there is another way we could fix this...
> like maybe not appending the slash?  Or appending a default resource?
> Or changing jabber_id_new() to ignore a trailing slash?  I'm afraid
> that Jabber's normalize function gets called often and the extra
> strlen and strdup could be expensive.
> 
> -Mark


How does the attached patch look? I'm not sure if other prpls use (and
expect) the last separator to be appended even when the last field is
empty, so . This version should be less memory-happy.

~Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: better-jid-normalization.patch
Type: text/x-patch
Size: 4266 bytes
Desc: not available
URL: <http://pidgin.im/pipermail/devel/attachments/20090826/56d52432/attachment-0002.bin>


More information about the Devel mailing list