purple_normalize called on NULL string causes a crash

[Sulabh Mahajan]

Hey all,

There are a few cases where purple_normalize() gets called with the string
argument set to NULL. purple_normalize() uses g_utf8_normalize() in case
prpl doesn't provide a normalize function. g_utf8_normalize() doesn't like a
NULL string argument, and causes a crash.
I have recently commited a revision, return NULL if purple_normalize() is
called on a NULL string. Should we add this check to purple_normalize() or
rather make sure that purple_normalize is not called on a NULL string at
all.

I suggest we should place the check in purple_normalize() apart from making
sure that the function doesn't get call in the specified way.


Thanks,

Sulabh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20090829/c33e4cbe/attachment-0001.html>